Update dev-tools to support Go Workspace #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the dev-tool code to support Go Workspace.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
belimawr
requested review from
ycombinator and
leehinman
and removed request for
a team
ycombinator
reviewed
May 30, 2023
| lines, err := getLines(callGo(nil, "list", "-m")) | ||
| // `go list -buildvcs=false -f '{{.Module}}'` produces the same output as `go list -m` | ||
| // and it works with go workspace | ||
| lines, err := getLines(callGo(nil, "list", "-buildvcs=false", "-f", "{{.Module}}")) |
There was a problem hiding this comment.
Do we need -buildvcs=false here? AFAICT it's not an option supported by go list. It looks like that option is only supported by go build. Also, running just go list -f {{.Module}} seems to work.
Suggested change
| lines, err := getLines(callGo(nil, "list", "-buildvcs=false", "-f", "{{.Module}}")) | |
| lines, err := getLines(callGo(nil, "list", "-f", "{{.Module}}")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit updates the dev-tool code to support Go Workspace.
Why is it important?
Go Workspaces facilitates working on multiple modules at the same time, Elastic-Agent and Beats share a number of modules and sometimes it's necessary to change more than one at once.
Checklist
~~- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added an entry inCHANGELOG.mdHow to test this PR locally
go work initPLATFORMSaccording to your platform)## Related issues